linux-kernel - Re: [PATCH] arm: use include/gen for mach-types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090418185226.GS26366@ZenIV.linux.org.uk>
Date:	Sat, 18 Apr 2009 19:52:26 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Russell King <rmk+lkml@....linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	takata@...ux-m32r.org, Christoph Hellwig <hch@....de>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: use include/gen for mach-types.h

On Sat, Apr 18, 2009 at 08:17:14PM +0200, Sam Ravnborg wrote:
> mach-types.h is a generated file.
> As we no longer has a .gitignore file in asm-arm the risk
> that somebody by accident commit mach-types.h is big.
> 
> Avoid this by the introduction of include/gen/ to
> hold this (and soon other) generated files.
> 
> The patch includes two small cleanups to arch/arm/Makefile.
> 1) delete stale comment
> 2) combine two targets in one line and drop unused prerequisite
> 
> The idea to introduce include/gen/ is originally from Al Viro.

Umm...
	a) why CLEAN_FILES and not MRPROPER_FILES?
	b) I'd simply add include/gen to MRPROPER_FILES in the top-level
Makefile.
	c) .gitignore in there ought to be simply *, if we want to create
.gitignore there at all (we don't do that for include/config and the
world doesn't end, after all).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/