linux-kernel - 2.6.30-rc2: format warning in fs/reiserfs/procfs.o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200904180843.11714.arvidjaar@mail.ru>
Date:	Sat, 18 Apr 2009 08:43:08 +0400
From:	Andrey Borzenkov <arvidjaar@...l.ru>
To:	reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: 2.6.30-rc2: format warning in fs/reiserfs/procfs.o

  CC [M]  fs/reiserfs/procfs.o
/home/bor/src/linux-git/fs/reiserfs/procfs.c: In function 'show_journal':
/home/bor/src/linux-git/fs/reiserfs/procfs.c:393: warning: format '%u' 
expects type 'unsigned int', but argument 22 has type 'long unsigned int'
  LD [M]  fs/reiserfs/reiserfs.o


Argument 22 is journal->j_last_flush_trans_id. As far as I can tell in all 
contexts where it is used it is assigned unsigned int (and journal->trans_id 
itself is unsigned int as well). So is this patch appropriate? It compiles 
cleanly, but I am a bit scared to test it on my sole root reiserfs :)

--

Subject: [PATCH] reiserfs: Make j_last_flush_trans_id unsigned int
From: Andrey Borzenkov <arvidjaar@...l.ru>

j_last_flush_trans_id is always assigned unsigned int value; so make it
unsigned int as well. It also removes this warning:

  CC [M]  fs/reiserfs/procfs.o
/home/bor/src/linux-git/fs/reiserfs/procfs.c: In function 'show_journal':
/home/bor/src/linux-git/fs/reiserfs/procfs.c:393: warning: format '%u'
expects type 'unsigned int', but argument 22 has type 'long unsigned int'

Signed-off-by: Andrey Borzenkov <arvidjaar@...l.ru>

---

 include/linux/reiserfs_fs_sb.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/include/linux/reiserfs_fs_sb.h b/include/linux/reiserfs_fs_sb.h
index 5621d87..1d1594a 100644
--- a/include/linux/reiserfs_fs_sb.h
+++ b/include/linux/reiserfs_fs_sb.h
@@ -193,7 +193,7 @@ struct reiserfs_journal {
 	atomic_t j_wcount;	/* count of writers for current commit */
 	unsigned long j_bcount;	/* batch count. allows turning X transactions 
into 1 */
 	unsigned long j_first_unflushed_offset;	/* first unflushed transactions 
offset */
-	unsigned long j_last_flush_trans_id;	/* last fully flushed journal 
timestamp */
+	unsigned int j_last_flush_trans_id;	/* last fully flushed journal 
timestamp */
 	struct buffer_head *j_header_bh;
 
 	time_t j_trans_start_time;	/* time this transaction started */


Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)