linux-kernel - Re: + mtd-mtd-in-mtd_release-is-unused-without-config_mtd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090418152635.125D.A69D9226@jp.fujitsu.com>
Date:	Sat, 18 Apr 2009 15:28:56 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	linux-kernel@...r.kernel.org, den@...nvz.org, dwmw2@...radead.org,
	linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	kosaki.motohiro@...fujitsu.com
Subject: Re: + mtd-mtd-in-mtd_release-is-unused-without-config_mtd_char.patch added to -mm tree

> Signed-off-by: Denis V. Lunev <den@...nvz.org>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/mtd/mtdcore.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff -puN drivers/mtd/mtdcore.c~mtd-mtd-in-mtd_release-is-unused-without-config_mtd_char drivers/mtd/mtdcore.c
> --- a/drivers/mtd/mtdcore.c~mtd-mtd-in-mtd_release-is-unused-without-config_mtd_char
> +++ a/drivers/mtd/mtdcore.c
> @@ -48,11 +48,11 @@ static LIST_HEAD(mtd_notifiers);
>   */
>  static void mtd_release(struct device *dev)
>  {
> -	struct mtd_info *mtd = dev_to_mtd(dev);
> +	dev_t index = MTD_DEVT(dev_to_mtd(dev));
>  
>  	/* remove /dev/mtdXro node if needed */
> -	if (MTD_DEVT(mtd->index))
> -		device_destroy(mtd_class, MTD_DEVT(mtd->index) + 1);
> +	if (index)
> +		device_destroy(mtd_class, index + 1);
>  }

I get compile failure problem on mmotm-0414.

=====================
mtd-mtd-in-mtd_release-is-unused-without-config_mtd_char.patch remove one
warnig if CONFIG_MTD_CHAR=n.

but it introduce one compile error if CONFIG_MTD_CHAR=y/m.

    drivers/mtd/mtdcore.c: In function ‘mtd_release’:
    drivers/mtd/mtdcore.c:51: error: invalid operands to binary * (have ‘struct mtd_info *’ and ‘int’)



Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc: Denis V. Lunev <den@...nvz.org>
Cc: David Woodhouse <dwmw2@...radead.org>
---
 drivers/mtd/mtdcore.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/mtd/mtdcore.c
===================================================================
--- a/drivers/mtd/mtdcore.c	2009-04-16 21:43:18.000000000 +0900
+++ b/drivers/mtd/mtdcore.c	2009-04-16 21:44:23.000000000 +0900
@@ -48,7 +48,7 @@ static LIST_HEAD(mtd_notifiers);
  */
 static void mtd_release(struct device *dev)
 {
-	dev_t index = MTD_DEVT(dev_to_mtd(dev));
+	dev_t index = MTD_DEVT(dev_to_mtd(dev)->index);
 
 	/* remove /dev/mtdXro node if needed */
 	if (index)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/