linux-kernel - Re: [PATCH] usb driver for intellon based PLC like devolo dlan duo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200904180938.48276.oliver@neukum.org>
Date:	Sat, 18 Apr 2009 09:38:47 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	"Peter Holik" <peter@...ik.at>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb driver for intellon based PLC like devolo dlan duo

Am Samstag 18 April 2009 09:16:28 schrieb Peter Holik:

> > +       len = (skb->data[skb->len - 2] | (skb->data[skb->len - 1] << 8));
> >
> > Please use a conversion function.
>
> do you mean
>
> len = le16_to_cpu(skb->data[skb->len - 2] | (skb->data[skb->len - 1] <<
> 8));

Without the "|". Just dereference the pointer.

>   pack_len &= 0x07ff;
>
>   len = (__le16 *) __skb_push(skb, INT51X1_HEADER_SIZE);
>   *len = cpu_to_le16(pack_len);

That's correct.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/