linux-kernel - [PATCH 1/1] edac: ppc mpc85xx fix mc err detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <49e925be.mjq9Fl6et5TONkn5%dougthompson@xmission.com>
Date:	Fri, 17 Apr 2009 18:58:38 -0600
From:	dougthompson@...ssion.com
To:	djiang@...sta.com, jharan@...cade.COM, dougthompson@...ssion.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: [PATCH 1/1] edac: ppc mpc85xx fix mc err detect

From: Dave Jiang <djiang@...sta.com>

Error found by Jeff Haran <jharan@...cade.COM>

The error detect register is 0s when no errors are detected.
The check code is incorrect, so reverse check sense.

Cc: Jeff Haran <jharan@...cade.COM>
Signed-off-by: Dave Jiang <djiang@...sta.com>
Signed-off-by: Doug Thompson <dougthompson@...ssion.com>

---
commit 1d8cad7d0ecbe9fad3c70b959804e6c6632e236c
tree ed8e099c0c0b775b1c11b94dfc794491a915e144
parent b0cbc861a3c05e634520b049b5cc27ad6febb51f
author Dave Jiang <djiang@...sta.com> Mon, 13 Apr 2009 10:16:53 -0700
committer Dave Jiang <djiang@...sta.com> Mon, 13 Apr 2009 10:16:53 -0700

 drivers/edac/mpc85xx_edac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index 4637a4a..7c8c2d7 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -674,7 +674,7 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci)
 	int row_index;
 
 	err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT);
-	if (err_detect)
+	if (!err_detect)
 		return;
 
 	mpc85xx_mc_printk(mci, KERN_ERR, "Err Detect Register: %#8.8x\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/