linux-kernel - Re: [PATCH 3/3] pci: don't printout if the bus res size is 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090418091633.GN7678@elte.hu>
Date:	Sat, 18 Apr 2009 11:16:33 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>, linux-pci@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] pci: don't printout if the bus res size is 0


* Yinghai Lu <yinghai@...nel.org> wrote:

> 
> also print out if it is prefetechable mmio
> 
> [Impact: cleanup]
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> 
> ---
>  drivers/pci/setup-bus.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6/drivers/pci/setup-bus.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/setup-bus.c
> +++ linux-2.6/drivers/pci/setup-bus.c
> @@ -558,11 +558,13 @@ static void pci_bus_dump_res(struct pci_
>  
>          for (i = 0; i < PCI_BUS_NUM_RESOURCES; i++) {
>                  struct resource *res = bus->resource[i];
> -                if (!res)
> +                if (!res || !res->end)
>                          continue;
>  
>  		dev_printk(KERN_DEBUG, &bus->dev, "resource %d %s %pR\n", i,
> -			   (res->flags & IORESOURCE_IO) ? "io: " : "mem:", res);
> +			   (res->flags & IORESOURCE_IO) ? "io: " :
> +			    ((res->flags & IORESOURCE_PREFETCH)? "pref mem":"mem:"),
> +			   res);

'pref mem' is easily mistaken for 'preferential memory' or something 
similar. Would printing "prefetchable-mem" still be OK?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/