linux-kernel - [PATCH] Don't print lockdep taint message for !LOCKDEP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090419173342.GA18041@basil.nowhere.org>
Date:	Sun, 19 Apr 2009 19:33:42 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	peterz@...radead.org, mingo@...hat.com,
	linux-kernel@...r.kernel.org
Subject: [PATCH] Don't print lockdep taint message for !LOCKDEP

Don't print lockdep taint message for !LOCKDEP

I was surprised to see a 

Disabling lockdep due to kernel taint

message in my lockdep disabled kernel. This patch ifdefs this message
to not be printed when lockdep is not enabled.

BTW in my case it was due to a thermal event. I'm not sure it's really
needed to disable lockdep on thermal events, but I left this alone for
now.

Signed-off-by: Andi Kleen <ak@...ux.intel.com>

---
 kernel/panic.c |    2 ++
 1 file changed, 2 insertions(+)

Index: linux-2.6.30-rc2-ak/kernel/panic.c
===================================================================
--- linux-2.6.30-rc2-ak.orig/kernel/panic.c	2009-04-15 11:14:36.000000000 +0200
+++ linux-2.6.30-rc2-ak/kernel/panic.c	2009-04-19 19:29:07.000000000 +0200
@@ -213,6 +213,7 @@
 
 void add_taint(unsigned flag)
 {
+#ifdef CONFIG_LOCKDEP
 	/*
 	 * Can't trust the integrity of the kernel anymore.
 	 * We don't call directly debug_locks_off() because the issue
@@ -222,6 +223,7 @@
 	 */
 	if (flag != TAINT_CRAP && flag != TAINT_WARN && __debug_locks_off())
 		printk(KERN_WARNING "Disabling lockdep due to kernel taint\n");
+#endif
 
 	set_bit(flag, &tainted_mask);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/