linux-kernel - Re: [PATCH] mfd: Mark clocks_init as non-init in twl4030-core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b9df5fa10904181959q5f544828ic4db185f0f9d9640@mail.gmail.com>
Date:	Sun, 19 Apr 2009 08:59:19 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	sameo@...ux.intel.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: Mark clocks_init as non-init in twl4030-core.c

On 4/19/09, Rakib Mullick <rakib.mullick@...il.com> wrote:
>  Impact: Fix section mismatch.
>
> clocks_init() has been called from twl4030_probe() which is a non-init
> function. Since probing can be done anytime so clocks_init will be
> called anytime too. So we mark clock_init() as non-init.
>
> LD      drivers/mfd/built-in.o
> WARNING: drivers/mfd/built-in.o(.text+0x8dd9): Section mismatch in
> reference from the function twl4030_probe() to the function
> .init.text:clocks_init()
> The function twl4030_probe() references
> the function __init clocks_init().
> This is often because twl4030_probe lacks a __init
> annotation or the annotation of clocks_init is wrong.
>
> ---
> Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
>
> --- linus/drivers/mfd/twl4030-core.c	2009-03-26 06:26:44.000000000 +0600
> +++ rakib/drivers/mfd/twl4030-core.c	2009-03-26 21:51:53.604077256 +0600
> @@ -649,7 +649,7 @@ static inline int __init unprotect_pm_ma
>  	return e;
>  }
>
> -static void __init clocks_init(struct device *dev)
> +static void clocks_init(struct device *dev)
>  {
>  	int e = 0;
>  	struct clk *osc;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/