linux-kernel - Re: [rtc-linux] Re: [PATCH/RFC 15/16] rtc: Add an RTC driver for the Ricoh RP5C01

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090419205652.44b0b7e9@i1501.lan.towertech.it>
Date:	Sun, 19 Apr 2009 20:56:52 +0200
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	rtc-linux@...glegroups.com
Cc:	geert@...ux-m68k.org, linux-m68k@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH/RFC 15/16] rtc: Add an RTC driver for
 the  Ricoh RP5C01

On Sun, 19 Apr 2009 20:41:21 +0200
Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> >  please implement either set_time or set_mmss, not both.
> >  I don't know the chip but I suspect set_time is the one you need.
> 
> OK, I will remove .set_mmss. Got to confused by looking into how
> everything is used...
> BTW, the only remaining users of rtc_set_mmss() seem to be
> arch/sparc/kernel/time_{32,64}.c?

 Yes. The facility is there for drives, not users. For some chips it's easier
 to implement a set_mmss like interface so it's better to have the rtc framewrk
 to convert between the twos than to have repeated code in drivers.

> OK, if I take the result (for both rtc-rp5c01 and rtc-msm6242) through
> the m68k tree?

 that's ok, you can add my acked by.
-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/