linux-kernel - Re: [PATCH] rtl8187se staging: Fix compilation warnings and procfs directory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090419053851.GA25290@kroah.com>
Date:	Sat, 18 Apr 2009 22:38:51 -0700
From:	Greg KH <greg@...ah.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	linux-kernel@...r.kernel.org,
	John W Linville <linville@...driver.com>,
	bernhard@...iffner-limbach.de
Subject: Re: [PATCH] rtl8187se staging: Fix compilation warnings and procfs
	directory leak

On Sat, Apr 18, 2009 at 09:09:08PM -0500, Larry Finger wrote:
> Fix some warnings during compilation and correct a programming error
> that was leaking a directory in /proc.
> 
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> Tested-by: Bernhard Schiffner <bernhard@...iffner-limbach.de>
> ---
> 
> Greg,
> 
> Please incorporate this patch in wireless/staging as soon as is possible.
> I'm not sure what the rules are concerning such changes.

I take stuff through my staging tree, it has nothing to do with the
wireless tree.

> I have a number of patches that clean up the vendor code; however, I think
> I will hold them for the moment as they do not change the function of this
> driver and only improve the readability.

Why wait?

> I am now working on porting this driver to use mac80211 so that it may be
> included in mainline.

That's great!

A few questions:

> --- linux-2.6.orig/drivers/staging/rtl8187se/r8180.h
> +++ linux-2.6/drivers/staging/rtl8187se/r8180.h
> @@ -19,7 +19,7 @@
>  #define R8180H
>  
>  
> -#define RTL8180_MODULE_NAME "rtl8180"
> +#define RTL8180_MODULE_NAME "r8180"

Why change the name?

> --- linux-2.6.orig/drivers/staging/rtl8187se/r8180_core.c
> +++ linux-2.6/drivers/staging/rtl8187se/r8180_core.c
> @@ -640,11 +640,9 @@ void rtl8180_proc_init_one(struct net_de
>  {
>  	struct proc_dir_entry *e;
>  	struct r8180_priv *priv = (struct r8180_priv *)ieee80211_priv(dev);
> -	priv->dir_dev = create_proc_entry(dev->name,
> -					  S_IFDIR | S_IRUGO | S_IXUGO,
> -					  rtl8180_proc);
> +	priv->dir_dev = rtl8180_proc;
>  	if (!priv->dir_dev) {
> -		DMESGE("Unable to initialize /proc/net/rtl8180/%s\n",
> +		DMESGE("Unable to initialize /proc/net/r8180/%s\n",
>  		      dev->name);
>  		return;
>  	}

So put the files in the root proc dir?

> @@ -1736,17 +1727,7 @@ short alloc_tx_desc_ring(struct net_devi
>  		 * descriptor's buffer must be 256 byte aligned
>  		 * we shouldn't be here, since we set DMA mask !
>  		 */
> -		DMESGW("Fixing TX alignment");
> -		desc = (u32*)((u8*)desc + 256);
> -#if (defined(CONFIG_HIGHMEM64G) || defined(CONFIG_64BIT_PHYS_ADDR))
> -		desc = (u32*)((u64)desc &~ 0xff);
> -		dma_desc = (dma_addr_t)((u8*)dma_desc + 256);
> -		dma_desc = (dma_addr_t)((u64)dma_desc &~ 0xff);
> -#else
> -		desc = (u32*)((u32)desc &~ 0xff);
> -		dma_desc = (dma_addr_t)((u8*)dma_desc + 256);
> -		dma_desc = (dma_addr_t)((u32)dma_desc &~ 0xff);
> -#endif
> +		WARN(1, "DMA buffer is not aligned\n");
>  	}
>  	tmp=desc;
>  	for (i=0;i<count;i++)

What replaces this logic?  Is it not needed anymore?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/