linux-kernel - Re: [PATCH] cs553x: fix build dependency problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090419200051.235089e9@ephemeral>
Date:	Sun, 19 Apr 2009 20:00:51 -0400
From:	Andres Salomon <dilinger@...ued.net>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	akpm@...ux-foundation.org, david-b@...bell.net,
	jordan@...micpenguin.net, katzj@...hat.com, tiwai@...e.de,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cs553x: fix build dependency problems

On Sat, 18 Apr 2009 18:01:18 -0700
Randy Dunlap <randy.dunlap@...cle.com> wrote:

> Andres, how does this look to you?
> 
> It fixes the problems that I know about.
> 
> 
> 

This may be okay as a separate patch, but doesn't really fix the problem.
cs553x-gpio isn't just for OLPC, it can be used by plain Geodes.  I've
lost track of the state of the patches at this point, but the solution
would be to simply have CONFIG_GPIO_CS553X depend upon PCI.




> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix multiple build errors due to cs553x-gpio using GPIO APIs
> and using PCI APIs.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  arch/x86/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- mmotm-2009-0417-1519.orig/arch/x86/Kconfig
> +++ mmotm-2009-0417-1519/arch/x86/Kconfig
> @@ -1969,7 +1969,8 @@ config GEODE_MFGPT_TIMER
>  
>  config OLPC
>  	bool "One Laptop Per Child support"
> -	select GPIO_CS553X
> +	select GPIO_CS553X if PCI
> +	select GPIOLIB if PCI
>  	default n
>  	---help---
>  	  Add support for detecting the unique features of the OLPC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/