linux-kernel - Re: [PATCH]8390p: Get rid of init_module/cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.0904201744380.13028@wotan.suse.de>
Date:	Mon, 20 Apr 2009 17:46:19 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Mateusz Mandera <ormi.linux@...il.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	p_gortmaker@...oo.com, trivial@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH]8390p: Get rid of init_module/cleanup_module

On Sat, 11 Apr 2009, Mateusz Mandera wrote:

> This trivial patch just "gets rid of" init_module and cleanup_module
> from drivers/net/8390p.c
> 
> Signed-off-by: Mateusz Mandera <ormi.linux@...il.com>
> ---
> diff --git a/drivers/net/8390p.c b/drivers/net/8390p.c
> index da863c9..ec9e3ca 100644
> --- a/drivers/net/8390p.c
> +++ b/drivers/net/8390p.c
> @@ -97,16 +97,15 @@ void NS8390p_init(struct net_device *dev, int startp)
>  }
>  EXPORT_SYMBOL(NS8390p_init);
> 
> -#if defined(MODULE)
> -
> -int init_module(void)
> +static int __init 8390p_init_module(void)
>  {
>  	return 0;
>  }
> 
> -void cleanup_module(void)
> +static void __exit 8390p_cleanup_module(void)
>  {
>  }
> 
> -#endif /* MODULE */
> +module_init(8390p_init_module);
> +module_exit(8390p_cleanup_module);
>  MODULE_LICENSE("GPL");

I'd rather have this merged through subsystem tree than trivial tree, 
adding netdev to CC.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/