linux-kernel - Re: [LTP] statvfs -> f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090420062642.GY26366@ZenIV.linux.org.uk>
Date:	Mon, 20 Apr 2009 07:26:42 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Michal Simek <michal.simek@...alogix.com>
Cc:	Nate Straz <nate-ltp@...ried.org>, subrata@...ux.vnet.ibm.com,
	ltp-list@...ts.sourceforge.net,
	John Williams <john.williams@...alogix.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [LTP] statvfs -> f_bavail

On Mon, Apr 20, 2009 at 08:16:50AM +0200, Michal Simek wrote:
> Nate Straz wrote:
> > On Apr 17 11:12, Michal Simek wrote:
> >   
> >>> don't you know what is the description of f_bavail in struct statvfs?
> >>> On my system I am getting zero for this entry that's why fsync02 failed.
> >>>   
> >>>       
> >> I track down where the problem comes from.
> >> There is problem for all fs which use simple_statfs function from
> >> fs/libfs.c.
> >> In open.c in vfs_statfs function is whole structure set to zero and then
> >> in simple_statfs not set this value.
> >> I think we should fix it in ltp code.
> >> Here is my proposed change. If is ok - I will generate proper patch.
> >>     
> >
> > If the problem is in the kernel, then it should be fixed in the kernel.
> > That's the whole point of LTP, pointing out problems in the kernel which
> > need to be fixed.  Patching LTP to work around f_bavail not being set
> > correctly is not the right thing to do.
> >   
> :-) And what about if is the kernel code ok? :-)
> Then IMHO is the right time to fix LTP.
> 
> The main question is if is or not.
> 
> Hi guys from linux-fsdevel: Can you told us what is the right solution
> for my problem above?

"Fields that are undefined for a particular file system are set to 0".
So what kind of fs are you running that on and is that sucker really
defined for it?  Note that if it's ramfs or tmpfs with -o nr_blocks=0,
there is no such thing as "amount of free space", reserved for root
or not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/