linux-kernel - Re: [PATCH] go7007: Convert to the new i2c device binding model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49ED781F.2000802@ladisch.de>
Date:	Tue, 21 Apr 2009 09:39:11 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	Greg Kroah-Hartman <gregkh@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] go7007: Convert to the new i2c device binding model

Jean Delvare wrote:
> I am puzzled by the s2250 I2C address, 0x86 really doesn't fit in
> 7 bits, there must be something wrong.

> -				.addr	= 0x34,
> +				.addr	= 0x86,	/* ?? */

> -#define S2250_VIDDEC        0x86

Many I2C controllers use an 8-bit address register, with the lowest bit
being the read/write bit (because this is the order in which the bits
are transmitted over the bus).  So it looks as if the actual address
_is_ 0x34; the S2250_VIDDEC symbol is probably a relict of the old
driver that programmed the I2C controller directly.


Best regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/