linux-kernel - Re: VIA Padlock driver no longer loads automatically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090421082645.GA22102@Chamillionaire.breakpoint.cc>
Date:	Tue, 21 Apr 2009 10:26:45 +0200
From:	Sebastian Andrzej Siewior <linux-crypto@...breakpoint.cc>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Chuck Ebbert <cebbert@...hat.com>, linux-kernel@...r.kernel.org,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: VIA Padlock driver no longer loads automatically

* Herbert Xu | 2009-04-21 13:56:13 [+0800]:

>On Tue, Apr 21, 2009 at 01:53:31PM +0800, Herbert Xu wrote:
>> 
>> Thanks for the report.  This patch should fix the problem.
>
>In fact, padlock-aes shouldn't have been aes-all in the first
>place so I'm going to add tihs patch too.
You changed all algos which need fallback to *-all to get them
probed/loaded after the generic algorithm. The same load/fallback/test
pattern exist for the s390 aes for instance. Should it be renamed as
well?

>commit acd246b7494c629aa617da49716409566cf52149
>Author: Herbert Xu <herbert@...dor.apana.org.au>
>Date:   Tue Apr 21 13:55:20 2009 +0800
>
>    crypto: padlock - Revert aes-all alias to aes
>    
>    Since the padlock-aes driver doesn't require a fallback (it's
>    only padlock-sha that does), it should use the aes alias rather
>    than aes-all so that ones that do need a fallback can use it.
>    
>    Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
>
>diff --git a/drivers/crypto/padlock-aes.c b/drivers/crypto/padlock-aes.c
>index 3f0fdd1..856b3cc 100644
>--- a/drivers/crypto/padlock-aes.c
>+++ b/drivers/crypto/padlock-aes.c
>@@ -489,4 +489,4 @@ MODULE_DESCRIPTION("VIA PadLock AES algorithm support");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Michal Ludvig");
> 
>-MODULE_ALIAS("aes-all");
>+MODULE_ALIAS("aes");
>
>Thanks,
>-- 

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/