linux-kernel - Re: [LTP] statvfs -> f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49ED87BF.7040007@petalogix.com>
Date:	Tue, 21 Apr 2009 10:45:51 +0200
From:	Michal Simek <michal.simek@...alogix.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Nate Straz <nate-ltp@...ried.org>, subrata@...ux.vnet.ibm.com,
	ltp-list@...ts.sourceforge.net,
	John Williams <john.williams@...alogix.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org, adilger@....com
Subject: Re: [LTP] statvfs -> f_bavail

Al Viro wrote:
> On Mon, Apr 20, 2009 at 08:42:13AM +0200, Michal Simek wrote:
>
>   
>> That mean that for all other fs is possible to set nr_blocks=0 (f_bavail=0) and for all this cases
>> fsync02 test failed. That mean that make sense to test f_bavail value in LTP and if is zero
>> don't work with it. Am I right?
>>     
>
> Huh?
> 	a) ramfs has no such thing as "amount of available space", simply
> because it has no limit on total size occupied.
>   
As wrote Andreas - for ramfs case make sense to use size of memory.

> 	b) tmpfs *does* have a limit and will report f_bavail, unless you
> tell it not to limit (that's what nr_blocks=... is; it sets the fs size limit
> for tmpfs and 0 means "no limit, act as ramfs").
>   
that mean that if is not limit make no sense to work with it in fsync02
test and use or default test value
or find out your fs size limit? Where is it written?

> 	c) nfs client has no fscking clue how much space is left on server
> for non-root; moreover, in case of nfs root on client might very well be
> mapped to something else on server.
>   
that mean that no make sense to work with f_bavail and return zero value
right?

> 	d) something local on-disk (ext2, ext3, etc., etc.) can and will fill
> ->f_bavail with non-zero data
>   
this is used.
> 	e) procfs has nothing to put there, period.  You can't create
> files there, it doesn't have anything like fixed-sized something that might
> be partially empty.
>   
snip
> The bottom line: some filesystems have reasonable answer to "how much space
> is left on that fs for non-root user".  Those fill the field in question.
> And for some filesystems the question makes no sense whatsoever.
>
> So statfs(2) has every right to leave the damn thing zero.  Whether it
> will do that or not depends on the fs type.  Userland code must be able
> to cope with that, unless it *knows* which filesystem type will it be
> dealing with.
>   
ok. Current LTP fsync02 failed in forever loop and my LTP patch just
solve problem if the f_bavail
is zero - if yes, just use default value which is in test.
Of course I would like to use sensible value(amount of mem or whatever)
for all fs and if is the way, I'll do it. That's question for you
if is possible to do it -> that's why I cc: fsdevel mailing list.
If is not a way to do it in generic way make sense to me use at least my
patch.

Michal
> Incidentally, nr_blocks=... will be cheerfully shat upon by just about every
> fs out there.  It's tmpfs-specific.
>   


-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/