linux-kernel - Re: [BUILD FAILURE 05/12] Next April 21 : PPC64 randconfig [drivers/macintosh/mediabay.o]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200904221134.18163.bzolnier@gmail.com>
Date:	Wed, 22 Apr 2009 11:34:17 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Paul Mackerras <paulus@...ba.org>
Cc:	subrata@...ux.vnet.ibm.com,
	"Linuxppc-dev" <Linuxppc-dev@...abs.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Stefan Bader <stefan.bader@...onical.com>,
	Marcelo Tosatti <marcelo@...ectiva.com.br>,
	Adrian Bunk <bunk@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-next" <linux-next@...r.kernel.org>,
	sachinp <sachinp@...ux.vnet.ibm.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Alexander Beregalov <a.beregalov@...il.com>
Subject: Re: [BUILD FAILURE 05/12] Next April 21 : PPC64 randconfig [drivers/macintosh/mediabay.o]

On Wednesday 22 April 2009 05:59:27 Paul Mackerras wrote:
> Bartlomiej Zolnierkiewicz writes:
> 
> > mediabay shouldn't include <linux/ide.h> unconditionally so
> > remove the superfluous include from mediabay.c (<asm/mediabay.h>
> > will pull <linux/ide.h> in for CONFIG_BLK_DEV_IDE_PMAC=y).
> 
> I don't like relying on second-hand imports like that.  I prefer the
> previous patch, that made mediabay depend on CONFIG_BLOCK.

I missed it somehow...

OK, I found it now and it should fix the problem as well.

> BTW, if including <linux/ide.h> causes an error when CONFIG_BLOCK=n,
> then there is a bug in <linux/ide.h>, IMO.

<linux/ide.h> is for drivers/ide only.  mediabay lacks proper abstraction
layer and is probably the only abuser left.

Besides being a build fix my patch is a right step in cleaning this mess
so I'm going to apply it through ide tree.

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/