linux-kernel - RE: [PATCH] usb/core/hub.c: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BD79186B4FD85F4B8E60E381CAEE19090165F056@mi8nycmail19.Mi8.com>
Date:	Wed, 22 Apr 2009 16:03:05 -0400
From:	"H Hartley Sweeten" <hartleys@...ionengravers.com>
To:	"Greg KH" <greg@...ah.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH]  usb/core/hub.c: fix sparse warnings

Fix sparse warning in drivers/usb/core/hub.c.

The following sparse warning is seen when building on ARM due
do the macro raw_local_irq_save():

	warning: symbol 'temp' shadows an earlier one

Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

---

Patch is also attached in case of line-wrapping.


diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index be86ae3..c7a1a1d 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -457,13 +457,13 @@ static void hub_tt_kevent (struct work_struct
*work)
 
 	spin_lock_irqsave (&hub->tt.lock, flags);
 	while (--limit && !list_empty (&hub->tt.clear_list)) {
-		struct list_head	*temp;
+		struct list_head	*next;
 		struct usb_tt_clear	*clear;
 		struct usb_device	*hdev = hub->hdev;
 		int			status;
 
-		temp = hub->tt.clear_list.next;
-		clear = list_entry (temp, struct usb_tt_clear,
clear_list);
+		next = hub->tt.clear_list.next;
+		clear = list_entry (next, struct usb_tt_clear,
clear_list);
 		list_del (&clear->clear_list);
 
 		/* drop lock so HCD can concurrently report other TT
errors */ 

Download attachment "usb_core_hub_c_sparse.patch" of type "application/octet-stream" (769 bytes)