linux-kernel - Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49EF7F34.9040401@caviumnetworks.com>
Date:	Wed, 22 Apr 2009 13:33:56 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	coly.li@...e.de
CC:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read()

Coly Li wrote:
> This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct
> clocksource *cs', which fixes compile warning for incompatible parameter type.
> 
> Signed-off-by: Coly Li <coly.li@...e.de>
> Cc: David Daney <ddaney@...iumnetworks.com>
> Cc: Ingo Molnar <mingo@...e.hu>

It looks good to me:

Reviewed-by: David Daney <ddaney@...iumnetworks.com>


> ---
>  arch/mips/cavium-octeon/csrc-octeon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/cavium-octeon/csrc-octeon.c
> b/arch/mips/cavium-octeon/csrc-octeon.c
> index 70fd92c..96110f2 100644
> --- a/arch/mips/cavium-octeon/csrc-octeon.c
> +++ b/arch/mips/cavium-octeon/csrc-octeon.c
> @@ -38,7 +38,7 @@ void octeon_init_cvmcount(void)
>  	local_irq_restore(flags);
>  }
> 
> -static cycle_t octeon_cvmcount_read(void)
> +static cycle_t octeon_cvmcount_read(struct clocksource *cs)
>  {
>  	return read_c0_cvmcount();
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/