linux-kernel - [PATCH] include/linux/pktcdvd.h: add mempool.h dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090422063833.GA23258@elte.hu>
Date:	Wed, 22 Apr 2009 08:38:33 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Beregalov <a.beregalov@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Peter Osterlund <petero2@...ia.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency


* Ingo Molnar <mingo@...e.hu> wrote:

> A last-minute build error slipped through:
>
>   In file included from fs/compat_ioctl.c:105:
>   include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ‘mempool_t’

Caused by:

  1ba0c7d: fs/compat_ioctl: fix build when !BLOCK

fixed by the patch below. The build error itself triggers with 
!BLOCK

	Ingo

------------------>
>From f8b664b0e6ad3369a998379e7f87297082d04bef Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Wed, 22 Apr 2009 08:29:40 +0200
Subject: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

A change to the order of header files in fs/compat_ioctl.c
unearthed a dormant header file dependency bug:

  In file included from fs/compat_ioctl.c:105:
  include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ‘mempool_t’

pktcdvd.h relies on mempool_t but does not include mempool.h.
This worked until now accidentally: due to other headers including
mempool.h in compat_ioctl.c (and all other pktcdvd.h using sites).
But once the header file broke this implicit dependency got
uncovered and an uncleanliness turned into a build failure.

Add mempool.h to pktcdvd.h.

[ Impact: fix build on !CONFIG_BLOCK ]

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 include/linux/pktcdvd.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
index 04b4d73..9cabc20 100644
--- a/include/linux/pktcdvd.h
+++ b/include/linux/pktcdvd.h
@@ -112,6 +112,7 @@ struct pkt_ctrl_command {
 #include <linux/completion.h>
 #include <linux/cdrom.h>
 #include <linux/kobject.h>
+#include <linux/mempool.h>
 #include <linux/sysfs.h>
 
 /* default bio write queue congestion marks */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/