linux-kernel - Re: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Apr 2009 08:42:34 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Beregalov <a.beregalov@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Peter Osterlund <petero2@...ia.com>,
	Sam Ravnborg <sam@...nborg.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency


* Ingo Molnar <mingo@...e.hu> wrote:

> Caused by:
> 
>   1ba0c7d: fs/compat_ioctl: fix build when !BLOCK
> 
> fixed by the patch below. The build error itself triggers with 
> !BLOCK
         [ ... so it is not very significant. ]

> pktcdvd.h relies on mempool_t but does not include mempool.h. This 
> worked until now accidentally: due to other headers including 
> mempool.h in compat_ioctl.c (and all other pktcdvd.h using sites). 
> But once the header file broke this implicit dependency got 
> uncovered and an uncleanliness turned into a build failure.
> 
> Add mempool.h to pktcdvd.h.

I think Sam's new include file self-sufficiency build checker could 
have caught it. (but there's a baseline to fix first: we have dozens 
and dozens of general purpose headers that do not build in a 
standalone .c file)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/