linux-kernel - Re: [PATCH] Eliminate thousands of warnings in WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090423121801.GM13896@one.firstfloor.org>
Date:	Thu, 23 Apr 2009 14:18:01 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Jesper Nilsson <jesper.nilsson@...s.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"torvalds@...l.org" <torvalds@...l.org>,
	"akpm@...l.org" <akpm@...l.org>
Subject: Re: [PATCH] Eliminate thousands of warnings in WARN_ON with gcc 3.2 build

On Thu, Apr 23, 2009 at 01:58:46PM +0200, Jesper Nilsson wrote:
> >  
> >  #ifdef WANT_WARN_ON_SLOWPATH
> > -void warn_slowpath(const char *file, int line, const char *fmt, ...)
> > +void warn_slowpath_fmt(const char *file, int line, const char *fmt, ...)
> >  {
> >  	va_list args;
> >  	char function[KSYM_SYMBOL_LEN];
> > @@ -358,7 +358,7 @@
> >  	if (board)
> >  		printk(KERN_WARNING "Hardware name: %s\n", board);
> >  
> > -	if (fmt) {
> > +	if (*fmt) {
> 
> Is this completely safe? If somebody is stupid enough to call
> WARN(condition, NULL); this won't work as it did before.
> OTOH, it would still be useless in debugging...

Noone in tree does according to grep. I would also argue
anyone doing that to be really broken.

> 
> Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>

Thanks.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/