linux-kernel - Re: [PATCH 09/14] block: clean up request completion API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49EFC360.3010109@kernel.org>
Date:	Thu, 23 Apr 2009 10:24:48 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Christoph Hellwig <hch@...radead.org>
CC:	axboe@...nel.dk, linux-kernel@...r.kernel.org, bzolnier@...il.com
Subject: Re: [PATCH 09/14] block: clean up request completion API

Christoph Hellwig wrote:
>> +EXPORT_SYMBOL_GPL(__blk_end_io);
> 
> That's really ugly code due to the locked argument.

Yeap, it's ugly.  Thought having one ugly path would be better than
duplicate implementations.

> Just make a helper for all code down to add_disk_randomness, and
> have two different functions call that and finish_request +/- the
> locking.

Alright, will change toward that direction.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/