linux-kernel - [PATCH] lib: find_last_bit.o needed by a module only, move it from lib to obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1240494032-9674-1-git-send-email-bhalevy@panasas.com>
Date:	Thu, 23 Apr 2009 16:40:32 +0300
From:	Benny Halevy <bhalevy@...asas.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, Fred Isaman <iisaman@...i.umich.edu>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	Benny Halevy <bhalevy@...asas.com>
Subject: [PATCH] lib: find_last_bit.o needed by a module only, move it from lib to obj

From: Fred Isaman <iisaman@...i.umich.edu>

Currently, although find_last_bit is EXPORTed, it is statically linked with
the lernel and is referenced only under CONFIG_SMP.

When CONFIG_SMP is undefined and find_last_bit is referenced only by modules,
linking fails with:
ERROR: "find_last_bit" [fs/nfs/nfs.ko] undefined!

Cc: Rusty Russell <rusty@...tcorp.com.au>
Cc: Trond Myklebust <Trond.Myklebust@...app.com>
Signed-off-by: Fred Isaman <iisaman@...i.umich.edu>
Signed-off-by: Benny Halevy <bhalevy@...asas.com>
---

Linus, can you please merge this trivial patch upstream?
This breaks nfs-2.6/{nfsv41,linux-next} on uni-processors
configured with !CONFIG_SMP.

Thanks,

Benny

 lib/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/Makefile b/lib/Makefile
index d6edd67..33a40e4 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -38,7 +38,7 @@ lib-$(CONFIG_RWSEM_GENERIC_SPINLOCK) += rwsem-spinlock.o
 lib-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
 lib-$(CONFIG_GENERIC_FIND_FIRST_BIT) += find_next_bit.o
 lib-$(CONFIG_GENERIC_FIND_NEXT_BIT) += find_next_bit.o
-lib-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
+obj-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
 obj-$(CONFIG_GENERIC_HWEIGHT) += hweight.o
 obj-$(CONFIG_LOCK_KERNEL) += kernel_lock.o
 obj-$(CONFIG_DEBUG_PREEMPT) += smp_processor_id.o
-- 
1.6.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/