| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1240498045-14288-3-git-send-email-jack@suse.cz> Date: Thu, 23 Apr 2009 16:47:23 +0200 From: Jan Kara <jack@...e.cz> To: LKML <linux-kernel@...r.kernel.org> Cc: Christoph Hellwig <hch@...radead.org>, Trond Myklebust <trond.myklebust@....uio.no>, linux-fsdevel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz> Subject: [PATCH 2/4] vfs: Call ->sync_fs() even if s_dirt is 0 (version 2) sync_filesystems() has a condition that if wait == 0 and s_dirt == 0, then ->sync_fs() isn't called. This does not really make much sence since s_dirt is generally used by a filesystem to mean that ->write_super() needs to be called. But ->sync_fs() does different things. I even suspect that some filesystems (btrfs?) sets s_dirt just to fool this logic. Signed-off-by: Jan Kara <jack@...e.cz> --- fs/super.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/super.c b/fs/super.c index 4826540..d9759e0 100644 --- a/fs/super.c +++ b/fs/super.c @@ -490,7 +490,7 @@ restart: spin_unlock(&sb_lock); down_read(&sb->s_umount); async_synchronize_full_domain(&sb->s_async_list); - if (sb->s_root && (wait || sb->s_dirt)) + if (sb->s_root) sb->s_op->sync_fs(sb, wait); up_read(&sb->s_umount); /* restart only when sb is no longer on the list */ -- 1.6.0.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists