linux-kernel - Re: [PATCH] Eliminate thousands of warnings in WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090423152323.GQ13896@one.firstfloor.org>
Date:	Thu, 23 Apr 2009 17:23:23 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, torvalds@...l.org, akpm@...l.org
Subject: Re: [PATCH] Eliminate thousands of warnings in WARN_ON with gcc 3.2 build

On Thu, Apr 23, 2009 at 08:07:51AM -0700, Arjan van de Ven wrote:
> Andi Kleen wrote:
> >On Thu, Apr 23, 2009 at 04:38:59PM +0200, Johannes Weiner wrote:
> >>>+void warn_slowpath_null(const char *file, int line)
> >>>+{
> >>>+	warn_slowpath_fmt(file, line, (const char *) { 0 });
> >>>+}
> >>>+EXPORT_SYMBOL(warn_slowpath_null);
> >>I would WTF here without knowing the warning.  Can you add a comment?
> >>
> >>Otherwise, Acked-by: Johannes Weiner <hannes@...xchg.org>
> >
> >Ok version with comment.
> 
> Makes sense if we plan to keep gcc 3.2 supported; if we plan to drop it 
> then we shouldn't bother.

It helps even for other compilers for code size, at least it shrunk Johannes' 
kernel by about 3k

> Acked-by: Arjan van de Ven <arjan@...ux.intel.com>

Thanks.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/