linux-kernel - Re: [patch 1/2] slub: rename cpuslab_flush to cpu_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020904231239i813959dobe85b8c56cbf8887@mail.gmail.com>
Date:	Thu, 23 Apr 2009 22:39:39 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 1/2] slub: rename cpuslab_flush to cpu_slab_flush

Hi David,

On Thu, Apr 23, 2009 at 9:38 PM, David Rientjes <rientjes@...gle.com> wrote:
> There is already a `cpu_slabs' file to display the number of cpu slabs,
> so cpuslab_flush should follow this pattern.
>
> The first documentation of this file will be in a subsequent patch that
> adds Documentation/ABI/testing/sysfs-kernel-slab, so no stable guarantee
> has been made that the name of this file would not change.

I'm afraid I don't have enough asbestos in my underwear to try to
sneak this one past Linus.

A kernel ABI is an ABI even if it's not documented. Now, I wouldn't
mind getting flamed if we actually gained something from the change.
But just fixing a simple typo in sysfs files is not big enough a
reason for me to merge the patch.

That said, I love the second patch though and am more than happy to take it.

                                          Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/