linux-kernel - Re: [PATCH 02/22] Do not sanity check order in the fast path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Apr 2009 12:45:30 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	Mel Gorman <mel@....ul.ie>
Cc:	Linux Memory Management List <linux-mm@...ck.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Nick Piggin <npiggin@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lin Ming <ming.m.lin@...el.com>,
	Zhang Yanmin <yanmin_zhang@...ux.intel.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 02/22] Do not sanity check order in the fast path

On Thu, 2009-04-23 at 12:26 -0700, Dave Hansen wrote:
> I'm going to retry this with a NUMA config.  

Oddly enough, removing the alloc_pages() check didn't do anything to
text on a NUMA=y config, either: 

dave@...nel:~/work/mhp-build$ size i386-numaq-sparse.?/vmlinux
   text	   data	    bss	    dec	    hex	filename
3460792	 449336	1626112	5536240	 5479f0	i386-numaq-sparse.0/vmlinux
3460792	 449336	1626112	5536240	 5479f0	i386-numaq-sparse.1/vmlinux
3460776	 449336	1626112	5536224	 5479e0	i386-numaq-sparse.2/vmlinux

Here's bloatmeter from removing the alloc_pages_node() check:

dave@...nel:~/work/mhp-build$ ../linux-2.6.git/scripts/bloat-o-meter
i386-numaq-sparse.{1,2}/vmlinux 
add/remove: 0/0 grow/shrink: 9/16 up/down: 81/-99 (-18)
function                                     old     new   delta
st_int_ioctl                                2600    2624     +24
tcp_sendmsg                                 2153    2169     +16
diskstats_show                               739     753     +14
iov_shorten                                   49      58      +9
unmap_vmas                                  1653    1661      +8
sg_build_indirect                            449     455      +6
ahc_linux_biosparam                          251     253      +2
nlmclnt_call                                 557     558      +1
do_mount                                    1533    1534      +1
skb_icv_walk                                 420     419      -1
nfs_readpage_truncate_uninitialised_page     288     287      -1
find_first_zero_bit                           67      66      -1
enlarge_buffer                               339     337      -2
ahc_parse_msg                               2340    2338      -2
__get_free_pages                              36      33      -3
flock_lock_file_wait                         484     480      -4
find_vma_prepare                             108     103      -5
arp_ignore                                   104      99      -5
__udp4_lib_err                               312     307      -5
alloc_buddy_huge_page                        170     163      -7
pbus_size_mem                                907     899      -8
dma_generic_alloc_coherent                   245     236      -9
cache_alloc_refill                          1168    1158     -10
mempool_alloc_pages                           33      17     -16
do_mremap                                   1208    1188     -20


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/