linux-kernel - Re: [PATCH] mm/vmalloc.c: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Apr 2009 21:35:57 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmalloc.c: fix sparse warning

On Thu, Apr 23, 2009 at 01:23:58PM -0700, Andrew Morton wrote:
> On Fri, 17 Apr 2009 20:55:06 -0400
> "H Hartley Sweeten" <hartleys@...ionengravers.com> wrote:
> 
> > Fix sparse warning in mm/vmalloc.c.
> > 
> >   warning: symbol 'tmp' shadows an earlier one

Folks, could we please add to appropriate documentation (SubmittingPatches,
perhaps) a bit about using descriptive subjects?

In general, "$TOOL warning in $FILE" says nothing useful.  In this case
"Get rid of shadowed variable in mm/vmalloc.c:<function>" would be far
more useful, with "found by sparse" _maybe_ showing up in the commit
message more or less as a footnote.  Or even "shadowed variable in
mm/vmalloc.c:<function>".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/