linux-kernel - Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband supporting the predicable I/O bandwidth (range bandwidth)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090424.185823.104059944.ryov@valinux.co.jp>
Date:	Fri, 24 Apr 2009 18:58:23 +0900 (JST)
From:	Ryo Tsuruta <ryov@...inux.co.jp>
To:	baramsori72@...il.com
Cc:	righi.andrea@...il.com, menage@...gle.com,
	balbir@...ux.vnet.ibm.com, guijianfeng@...fujitsu.com,
	kamezawa.hiroyu@...fujitsu.com, agk@...rceware.org,
	akpm@...ux-foundation.org, axboe@...nel.dk, chlunde@...g.uio.no,
	dave@...ux.vnet.ibm.com, dpshah@...gle.com, eric.rannaud@...il.com,
	fernando@....ntt.co.jp, taka@...inux.co.jp, lizf@...fujitsu.com,
	matt@...ehost.com, dradford@...ehost.com, ngupta@...gle.com,
	randy.dunlap@...cle.com, roberto@...it.it, s-uchida@...jp.nec.com,
	subrata@...ux.vnet.ibm.com, yoshikawa.takuya@....ntt.co.jp,
	nauman@...gle.com, fchecconi@...il.com, paolo.valente@...more.it,
	containers@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, corsetproject@...glegroups.com
Subject: Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband
 supporting the predicable I/O bandwidth (range bandwidth)

Hi Dong-Jae,

> range-bw is based on newest version of dm-ioband, bio-cgroup V7(4
> patch files), dm-ioband-V1.10.3(1 patch file) and these can be
> referred in
> http://people.valinux.co.jp/~ryov/dm-ioband/
> http://people.valinux.co.jp/~ryov/bio-cgroup/
> and the below range-bw patch file(dm-ioband-rangebw-1.10.3.patch)
> including Ryo’s patch set is also referred in:
> http://www.corsetproject.net/browser/corset_source_code/resource_controllers/disk_controller/Range-BW-for-dmioband-V1.10.3
> You have to apply this(dm-ioband-rangebw-1.10.3.patch) patch file
> after applying dm-ioband and bio-cgroup patches.
> 
> The released range-bw may have some problems and improper code
> although I try to test heavily. It is first release ^^
> And it is required to reduce the overhead of I/O scheduling and to
> optimize the source code.
> Any comments or advices is welcome
> 
> Ryo Tsuruta, Can you check this patch file ?
> for convenience, patch file is attached in this mail.

I took a quick look at your patch. It seems to be no problem for
existing dm-ioband code, but I would suggest you that you had better
use checkpatch.pl to check for your coding style.
The patch could be applied and compiled successfully. I did a simple
test, running fio on each cgroup in 30 seconds simultaneously, and got
the following results.

               w/o range-bw     w/ range-bw (min&max-bw settings)
cgroup1          331KB/s             102KB/s (100KB)
cgroup2          331KB/s             196KB/s (200KB)

Do you have any benchmark resutls? I'd be very interested to see it.

Thanks,
Ryo Tsuruta