linux-kernel - Re: [PATCH 3/4] ptrace: remove PT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Apr 2009 11:17:01 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Oleg Nesterov <oleg@...hat.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Roland McGrath <roland@...hat.com>,
	Chris Zankel <chris@...kel.net>,
	David Howells <dhowells@...hat.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Greg Ungerer <gerg@...inux.org>,
	Haavard Skinnemoen <hskinnemoen@...el.com>,
	Helge Deller <deller@....de>,
	Hirokazu Takata <takata@...ux-m32r.org>,
	Jeff Dike <jdike@...toit.com>,
	Kyle McMartin <kyle@...artin.ca>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Mike Frysinger <vapier.adi@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Roman Zippel <zippel@...ux-m68k.org>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu


Oleg Nesterov wrote:
> m68k sets PT_DTRACE in trap_c() but never uses it.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Acked-by: Greg Ungerer <gerg@...inux.org>


>  arch/m68k/kernel/traps.c            |    1 -
>  arch/m68knommu/kernel/asm-offsets.c |    1 -
>  arch/m68knommu/kernel/traps.c       |    1 -
>  3 files changed, 3 deletions(-)
> 
> --- PTRACE/arch/m68k/kernel/traps.c~DT_3_SET	2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68k/kernel/traps.c	2009-04-22 21:52:23.000000000 +0200
> @@ -1057,7 +1057,6 @@ asmlinkage void trap_c(struct frame *fp)
>  	if (fp->ptregs.sr & PS_S) {
>  		if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
>  			/* traced a trapping instruction */
> -			current->ptrace |= PT_DTRACE;
>  		} else
>  			bad_super_trap(fp);
>  		return;
> --- PTRACE/arch/m68knommu/kernel/asm-offsets.c~DT_3_SET	2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68knommu/kernel/asm-offsets.c	2009-04-22 21:53:46.000000000 +0200
> @@ -79,7 +79,6 @@ int main(void)
>  	DEFINE(TRAP_TRACE, TRAP_TRACE);
>  
>  	DEFINE(PT_PTRACED, PT_PTRACED);
> -	DEFINE(PT_DTRACE, PT_DTRACE);
>  
>  	DEFINE(THREAD_SIZE, THREAD_SIZE);
>  
> --- PTRACE/arch/m68knommu/kernel/traps.c~DT_3_SET	2009-04-06 00:03:35.000000000 +0200
> +++ PTRACE/arch/m68knommu/kernel/traps.c	2009-04-22 21:54:29.000000000 +0200
> @@ -200,7 +200,6 @@ asmlinkage void trap_c(struct frame *fp)
>  	if (fp->ptregs.sr & PS_S) {
>  		if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
>  			/* traced a trapping instruction */
> -			current->ptrace |= PT_DTRACE;
>  		} else
>  			bad_super_trap(fp);
>  		return;
> 
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/