linux-kernel - Re: [PATCH 3/4] ptrace: remove PT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10f740e80904240357r63fc9d4i5f8a4e6a5530b671@mail.gmail.com>
Date:	Fri, 24 Apr 2009 12:57:09 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Andreas Schwab <schwab@...ux-m68k.org>,
	Roman Zippel <zippel@...ux-m68k.org>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Roland McGrath <roland@...hat.com>,
	Chris Zankel <chris@...kel.net>,
	David Howells <dhowells@...hat.com>,
	Greg Ungerer <gerg@...inux.org>,
	Haavard Skinnemoen <hskinnemoen@...el.com>,
	Helge Deller <deller@....de>,
	Hirokazu Takata <takata@...ux-m32r.org>,
	Jeff Dike <jdike@...toit.com>,
	Kyle McMartin <kyle@...artin.ca>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Mike Frysinger <vapier.adi@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] ptrace: remove PT_DTRACE from m68k, m68knommu

On Fri, Apr 24, 2009 at 12:06, Andreas Schwab <schwab@...ux-m68k.org> wrote:
> Oleg Nesterov <oleg@...hat.com> writes:
>
>> m68k sets PT_DTRACE in trap_c() but never uses it.
>>
>> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
>>
>>  arch/m68k/kernel/traps.c            |    1 -
>>  arch/m68knommu/kernel/asm-offsets.c |    1 -
>>  arch/m68knommu/kernel/traps.c       |    1 -
>>  3 files changed, 3 deletions(-)
>>
>> --- PTRACE/arch/m68k/kernel/traps.c~DT_3_SET  2009-04-06 00:03:35.000000000 +0200
>> +++ PTRACE/arch/m68k/kernel/traps.c   2009-04-22 21:52:23.000000000 +0200
>> @@ -1057,7 +1057,6 @@ asmlinkage void trap_c(struct frame *fp)
>>       if (fp->ptregs.sr & PS_S) {
>>               if ((fp->ptregs.vector >> 2) == VEC_TRACE) {
>>                       /* traced a trapping instruction */
>> -                     current->ptrace |= PT_DTRACE;
>
> This is supposed to be setting the TIF_DELAYED_TRACE thread flag.

This code already looks different in the m68k tree, due to your fix to
`Allow all kernel traps to be handled via exception fixups' for
ARAnyM, and some related cleanups by you and Roman.

But more interestingly, Roman's last cleanup said there's no need to
set TIF_DELAYED_TRACE?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/