linux-kernel - Re: [PATCH 09/22] Calculate the alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090424105115.18fec653.akpm@linux-foundation.org>
Date:	Fri, 24 Apr 2009 10:51:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mel Gorman <mel@....ul.ie>
Cc:	linux-mm@...ck.org, kosaki.motohiro@...fujitsu.com,
	cl@...ux-foundation.org, npiggin@...e.de,
	linux-kernel@...r.kernel.org, ming.m.lin@...el.com,
	yanmin_zhang@...ux.intel.com, peterz@...radead.org,
	penberg@...helsinki.fi
Subject: Re: [PATCH 09/22] Calculate the alloc_flags for allocation only
 once

On Fri, 24 Apr 2009 11:47:17 +0100 Mel Gorman <mel@....ul.ie> wrote:

> Uninline gfp_to_alloc_flags() in the page allocator slow path

Well, there are <boggle> 37 inlines in page_alloc.c, so uninlining a
single function (and leaving its layout mucked up ;)) is a bit random.

Perhaps sometime you could take a look at "[patch] page allocator:
rationalise inlining"?

I'm kind of in two minds about it.  Do we really know that all approved
versions of gcc will do the most desirable thing in all circumstances
on all architectures?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/