linux-kernel - Re: [patch 01/27] fs: cleanup files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Apr 2009 22:35:10 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	npiggin@...e.de
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Al Viro <viro@...IV.linux.org.uk>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [patch 01/27] fs: cleanup files_lock

npiggin@...e.de writes:

> Lock tty_files with tty_mutex, provide helpers to manipulate the per-sb
> files list, and unexport the files_lock spinlock.

This conflicts a bit with some of my ongoing work, which is generalizing
the file list to make it more useful and makes the tty case much less
of a special case.

Do you know if the performance improvement would be anywhere near as good if
file_list and file_list_lock becoming per inode?

Do you have any idea what the performance improvement with changing the file_list_lock
is?


> Index: linux-2.6/fs/open.c
> ===================================================================
> --- linux-2.6.orig/fs/open.c
> +++ linux-2.6/fs/open.c
> @@ -828,7 +828,7 @@ static struct file *__dentry_open(struct
>  	f->f_path.mnt = mnt;
>  	f->f_pos = 0;
>  	f->f_op = fops_get(inode->i_fop);
> -	file_move(f, &inode->i_sb->s_files);
> +	file_sb_list_add(f, inode->i_sb);

You can make this just:
	 if (!special_file(inode->i_mode))
		file_add(f, &inode->i_files);

And save yourself a lot of complexity.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/