linux-kernel - Re: [PATCH 2/2] regulator: add userspace-consumer driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090426120036.GA10900@opensource.wolfsonmicro.com>
Date:	Sun, 26 Apr 2009 13:00:37 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Mike Rapoport <mike@...pulab.co.il>
Cc:	lrg@...mlogic.co.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: add userspace-consumer driver

On Sun, Apr 26, 2009 at 02:47:04PM +0300, Mike Rapoport wrote:
> Mark Brown wrote:

> > Why are you using a regulator_consumer_supply here?  All that's being
> > used here is the name and I can't see why you'd want the device.

> For upwards compatibility :)
> Well, seriously, I think using 'struct regulator_consumer_supply *supplies'
> rather than 'char *supplies' makes the platform code that registers the
> userspace-consumer device clearer.

On the other hand it merges the consumer and machine APIs, which we
really want to keep separate, and I can't see having the struct device
in there doing anything except confuse people.  If you're going to pick
an existing structure to use I'd be more inclined to use the bulk
consumer structure (which the driver needs to allocate anyway).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/