linux-kernel - Re: [PATCH 14/15] x86: convert to use __HEAD and HEAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Apr 2009 11:56:44 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Sam Ravnborg <sam@...nborg.org>
cc:	Tim Abbott <tabbott@....EDU>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Anders Kaseorg <andersk@....EDU>,
	Waseem Daher <wdaher@....EDU>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andi Kleen <andi@...stfloor.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Jeff Arnold <jbarnold@....EDU>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jon Masters <jonathan@...masters.org>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	"Theodore Ts'o" <tytso@....EDU>,
	Nikanth Karthikesan <knikanth@...e.de>,
	Arjan van de Ven <arjan@...radead.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	Américo Wang <xiyou.wangcong@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Kyle McMartin <kyle@...artin.ca>,
	David Howells <dhowells@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH 14/15] x86: convert to use __HEAD and HEAD_TEXT macros.



On Sun, 26 Apr 2009, Sam Ravnborg wrote:

> On Sun, Apr 26, 2009 at 10:12:47AM -0700, Linus Torvalds wrote:
> > 
> > 
> > On Sun, 26 Apr 2009, Linus Torvalds wrote:
> > > 
> > > Btw, this one really needs to unify the two lds files first. Look at 
> > > 
> > > 	diff -u arch/x86/boot/compressed/vmlinux_*.lds
> > > 
> > > output and realize that they're basially exctly the same except for 
> > > trivial naming differences, and the fact that the64-bit version hs a 
> > > "pgtable" thing.
> > > 
> > > So this really needs to be done by first unifying the thing so that there 
> > > is _one_ arch/x86/boot/compressed/vmlinux.lds.S file with a preprocessor 
> > > that takes care of the trivial differences [..]
> > 
> > Something like this?
> 
> Looks good/correct.
> Acked-by: Sam Ravnborg <sam@...nborg.org>
> 
> You should add your s-o-b if you expect Ingo to pick it up.

Sure. I don't tend to add SOB lines for stuff that I'd not be ready to 
commit, but with some testing and other people looking at it, I think it's 
good to go.

	Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>

As mentioned, though, the much more interesting case would be the _real_ 
kernel vmlinux.lds.S file, which is a lot more complex and where the 
differences between 32-bit and 64-bit cases aren't totally trivial.

Looking at 

	diff -u arch/x86/kernel/vmlinux_*.lds.S | less -S

output, many of them are just whitespace, and others are trivial and 
meaningless (comments in one, not the other, placement of alignment etc, 
different ordering of sections like "parainstructions"). Yet others seem 
to be things that we _could_ do in general, but that don't matter on one 
architecture or other (x86-64 has ".eh_frame" in the DISCARD section, i386 
apparently doesn't ever generate them, we could just use the x86-64 
version).

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/