linux-kernel - Re: [PATCH 5/5] tracing/events: make modules have their own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090426110526.GA10391@elte.hu>
Date:	Sun, 26 Apr 2009 13:05:26 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Greg KH <greg@...ah.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Li Zefan <lizf@...fujitsu.com>
Subject: Re: [PATCH 5/5] tracing/events: make modules have their own
	file_operations structure


* Greg KH <greg@...ah.com> wrote:

> On Sat, Apr 25, 2009 at 12:20:35AM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@...hat.com>
> > 
> > For proper module reference counting, the file_operations that modules use
> > must have the "owner" field set to the module. Unfortunately, the trace events
> > use share file_operations. The same file_operations are used by all both
> > kernel core and all modules.
> > 
> > This patch makes the modules allocate their own file_operations and
> > copies the functions from the core kernel. This allows those file
> > operations to be owned by the module.
> > 
> > Care is taken to free this code on module unload.
> > 
> > Thanks to Greg KH for reminding me that file_operations must be owned
> > by the module to have reference counting take place.
> > 
> > Cc: Greg KH <greg@...ah.com>
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> Looks good, feel free to add an:
> 	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
> to it.

I've amended the final commit with your ack - thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/