linux-kernel - Re: [PATCH 10/30] microblaze_mmu_v1: Context handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200904271255.08500.arnd@arndb.de>
Date:	Mon, 27 Apr 2009 12:55:08 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	monstr@...str.eu
Cc:	linux-kernel@...r.kernel.org, john.williams@...alogix.com
Subject: Re: [PATCH 10/30] microblaze_mmu_v1: Context handling - mmu_context.c/h

On Monday 27 April 2009, monstr@...str.eu wrote:
>  arch/microblaze/include/asm/mmu_context.h |  134 +++++++++++++++++++++++++++++
>  arch/microblaze/mm/mmu_context.c          |   70 +++++++++++++++
>  2 files changed, 204 insertions(+), 0 deletions(-)
>  create mode 100644 arch/microblaze/mm/mmu_context.c
> 

Your mmu_context.h is basically

#ifdef CONFIG_MMU
 /* MMU code */
#else
 /* NOMMU code */
#endif

but doesn't have any shared code at all. In cases like this, I'd
recommend having three separate files as m68k does: mmu_context_no.h
mmu_context_mm.h and mmu_context.h that has a simple switch between
them.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/