linux-kernel - Re: Subject: [tip:irq/genirq] genirq: assert that irq handlers are indeed running in hardirq context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200904270405.09206.david-b@pacbell.net>
Date:	Mon, 27 Apr 2009 04:05:09 -0700
From:	David Brownell <david-b@...bell.net>
To:	lkml <linux-kernel@...r.kernel.org>
Subject: Re:  Subject:    [tip:irq/genirq] genirq: assert that irq handlers are indeed running in hardirq context

> Commit-ID:  044d408409cc4e1bc75c886e27ca85c270db104c
> Gitweb:    
> http://git.kernel.org/tip/044d408409cc4e1bc75c886e27ca85c270db104c Author: 
>    Peter Zijlstra <a.p.zijlstra@...llo.nl>
> AuthorDate: Mon, 2 Mar 2009 16:13:32 +0100
> Commit:     Ingo Molnar <mingo@...e.hu>
> CommitDate: Tue, 3 Mar 2009 00:05:45 +0100
>
> genirq: assert that irq handlers are indeed running in hardirq context
>
> Make sure the genirq layer handlers are indeed running handlers
> in hardirq context. That is the genirq expectation and doing
> anything else is broken.

Actually, it's more like Peter Zijlstra's expectation.
Genirq works perfectly well without this.

And ... this causes regressions, so I suggest it get
reverted ASAP.

http://marc.info/?l=linux-kernel&m=124082644212584&w=2


>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> LKML-Reference: <1236006812.5330.632.camel@...top>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
>
>
> ---
>  kernel/irq/handle.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index 3aba8d1..a2ee682 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -328,6 +328,8 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct
> irqaction *action) irqreturn_t ret, retval = IRQ_NONE;
>  	unsigned int status = 0;
>
> +	WARN_ONCE(!in_irq(), "BUG: IRQ handler called from non-hardirq context!");

Notice also:  clearly untested.  No newline on the message.

> + 
>  	if (!(action->flags & IRQF_DISABLED))
>  		local_irq_enable_in_hardirq();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/