linux-kernel - Re: [git patches] Staging: rtxxx0: cleanup and "dumb" merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Apr 2009 08:40:22 -0700
From:	Greg KH <greg@...ah.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [git patches] Staging: rtxxx0: cleanup and "dumb" merge

On Mon, Apr 27, 2009 at 05:28:32PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 26 April 2009 20:39:54 Greg KH wrote:
> > On Sun, Apr 26, 2009 at 05:59:20PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > 
> > > Hi,
> > > 
> > > This patchset cleans up rt{286,287,307}0 drivers (66 KLOC removed) and then
> > > "dumb" (i.e. rt3070 shares code with rt2870 by including rt2870's .c files
> > > and depends on ifdefs to get the correct end result) merges them (142 KLOC
> > > removed).  All in all 208 KLOC are gone and we now use the common code for
> > > all three Ralink drivers.
> > 
> > Wonderful!
> > 
> > Were you able to test that this still works afterward?
> 
> I just used some semi-automatic verification of changes -- I scripted build
> process with comparing sizes of resulting .o files so when they were different
> I was re-auditing the given patch or (if re-audit didn't catch anything)
> comparing corresponding .s files.  This of course doesn't provide us with
> a complete proof that changes are correct but increases probability of such
> outcome significantly. :)

Heh :)

> The real testing with RT2860, RT2870 & RT3070 would be much welcomed...

Agreed.  I'll pull these into my tree and hopefully someone with the
hardware can test it out in linux-next.

Hm, wait, I think I have a laptop somewhere around here with one of
these devices, so I'll see if I can test it myself as well.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/