linux-kernel - Re: [2.6 patch] usb/storage/usual-tables.c: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090427163752.GA24310@localhost.pp.htv.fi>
Date:	Mon, 27 Apr 2009 19:37:52 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Greg KH <greg@...ah.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE

On Mon, Apr 27, 2009 at 08:28:19AM -0700, Greg KH wrote:
> On Mon, Apr 27, 2009 at 12:33:01PM +0300, Adrian Bunk wrote:
> > This patch adds the missing MODULE_LICENSE("GPL").
> > 
> > Signed-off-by: Adrian Bunk <bunk@...nel.org>
> > 
> > ---
> > 
> > diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> > index 468bde7..d62ea8f 100644
> > --- a/drivers/usb/storage/usual-tables.c
> > +++ b/drivers/usb/storage/usual-tables.c
> > @@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
> >  	return 0;
> >  }
> >  EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
> > +
> > +MODULE_LICENSE("GPL");
> 
> Why is this needed?  This .c file gets built into either the libusual
> module, or the usb-storage module, both of which have module licenses,
> right?

My fault, I ran into it some time ago, and missed that the actual 
problem was fixed by commit dfc15e8955338fedf5c5d15622c4042c1e4ee332

> confused,
> 
> greg k-h

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/