linux-kernel - Re: [PATCH 8/8] Remove unused support code for refok sections.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090427185156.GH12056@uranus.ravnborg.org>
Date:	Mon, 27 Apr 2009 20:51:56 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Tim Abbott <tabbott@....EDU>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Anders Kaseorg <andersk@....edu>,
	Waseem Daher <wdaher@....edu>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Jeff Arnold <jbarnold@....edu>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 8/8] Remove unused support code for refok sections.

On Mon, Apr 27, 2009 at 02:02:27PM -0400, Tim Abbott wrote:
> The old refok sections
> 
>   .text.init.refok
>   .data.init.refok
>   .exit.text.refok
> 
> have been deprecated since commit
> 312b1485fb509c9bc32eda28ad29537896658cb8.  After the other patches in
> this patch series nothing is put in these sections, so clean things up
> by eliminating all the remaining references to them.
> 
> Signed-off-by: Tim Abbott <tabbott@....edu>
> Cc: Sam Ravnborg <sam@...nborg.org>

I like this cleanup!
Acked-by: Sam Ravnborg <sam@...nborg.org>

> ---
>  include/asm-generic/vmlinux.lds.h |    3 ---
>  include/linux/init.h              |    8 --------
>  scripts/mod/modpost.c             |   18 ------------------
>  3 files changed, 0 insertions(+), 29 deletions(-)
> 
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index eaa06ef..89853bc 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -90,7 +90,6 @@
>  /* .data section */
>  #define DATA_DATA							\
>  	*(.data)							\
> -	*(.data.init.refok)						\
>  	*(.ref.data)							\
>  	DEV_KEEP(init.data)						\
>  	DEV_KEEP(exit.data)						\
> @@ -289,8 +288,6 @@
>  		*(.text.hot)						\
>  		*(.text)						\
>  		*(.ref.text)						\
> -		*(.text.init.refok)					\
> -		*(.exit.text.refok)					\
>  	DEV_KEEP(init.text)						\
>  	DEV_KEEP(exit.text)						\
>  	CPU_KEEP(init.text)						\
> diff --git a/include/linux/init.h b/include/linux/init.h
> index 20a1334..0e06c17 100644
> --- a/include/linux/init.h
> +++ b/include/linux/init.h
> @@ -62,14 +62,6 @@
>  #define __refdata        __section(.ref.data)
>  #define __refconst       __section(.ref.rodata)
>  
> -/* backward compatibility note
> - *  A few places hardcode the old section names:
> - *  .text.init.refok
> - *  .data.init.refok
> - *  .exit.text.refok
> - *  They should be converted to use the defines from this file
> - */
> -
>  /* compatibility defines */
>  #define __init_refok     __ref
>  #define __initdata_refok __refdata
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index df6e628..8d46ea7 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -794,15 +794,6 @@ static const char *init_exit_sections[] =
>  /* data section */
>  static const char *data_sections[] = { DATA_SECTIONS, NULL };
>  
> -/* sections that may refer to an init/exit section with no warning */
> -static const char *initref_sections[] =
> -{
> -	".text.init.refok*",
> -	".exit.text.refok*",
> -	".data.init.refok*",
> -	NULL
> -};
> -
>  
>  /* symbols in .data that may refer to init/exit sections */
>  static const char *symbol_white_list[] =
> @@ -915,11 +906,6 @@ static int section_mismatch(const char *fromsec, const char *tosec)
>  /**
>   * Whitelist to allow certain references to pass with no warning.
>   *
> - * Pattern 0:
> - *   Do not warn if funtion/data are marked with __init_refok/__initdata_refok.
> - *   The pattern is identified by:
> - *   fromsec = .text.init.refok* | .data.init.refok*
> - *
>   * Pattern 1:
>   *   If a module parameter is declared __initdata and permissions=0
>   *   then this is legal despite the warning generated.
> @@ -958,10 +944,6 @@ static int section_mismatch(const char *fromsec, const char *tosec)
>  static int secref_whitelist(const char *fromsec, const char *fromsym,
>  			    const char *tosec, const char *tosym)
>  {
> -	/* Check for pattern 0 */
> -	if (match(fromsec, initref_sections))
> -		return 0;
> -
>  	/* Check for pattern 1 */
>  	if (match(tosec, init_data_sections) &&
>  	    match(fromsec, data_sections) &&
> -- 
> 1.6.2.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/