linux-kernel - Re: [PATCH] Acer Aspire One Fan Control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cone.1240859015.836112.5316.1000@onepiie>
Date:	Mon, 27 Apr 2009 21:03:35 +0200
From:	Peter Feuerer <peter@...e.net>
To:	Joe Perches <joe@...ches.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, lenb@...nel.org,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: [PATCH] Acer Aspire One Fan Control

Hi Joe,

thanks for your email. A modified patch will follow soon.

>> + *  25-April-2009: Version 0.5:
>> + *  - ported to 2.6.30
>> + *  - removed kthread and used polling of thermal api
> 
> Version information in comments isn't generally useful

Will remove it.

> There's no other thermal device_mode state than ENABLED/DISABLED.
> Maybe just if/else?

Yes will do it.

>> +/* print the name of the trip point */
>> +static int get_trip_type(struct thermal_zone_device *thermal,
>> +		int trip, enum thermal_trip_type *type)
>> +{
>> +	if (trip == 0)
>> +		*type = THERMAL_TRIP_ACTIVE;
>> +	return 0;
>> +}
> 
> Comment doesn't match code.  I see no printing here.

Old comment, will correct it.

> You would #define pr_fmt(fmt) "acerhd: " fmt
> instead of prefixing all the printks with "acerhd:"

Jip, will do something like this.

kind regards,
--peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/