linux-kernel - Re: [PATCH -tip] remove the BKL: remove "BKL auto-drop" assumption from ext3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63a49ef40904271321k47e97c2y5da7f561c7591564@mail.gmail.com>
Date:	Mon, 27 Apr 2009 22:21:39 +0200
From:	Alessio Igor Bogani <abogani@...ware.it>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Jonathan Corbet <corbet@....net>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] remove the BKL: remove "BKL auto-drop" assumption 
	from ext3_remount()

Dear Sir Molnar,

2009/4/26 Ingo Molnar <mingo@...e.hu>:
[...]
>> +                     unlock_kernel();
>>                       unlock_super(sb);
>>                       ext3_mark_recovery_complete(sb, es);
>>                       lock_super(sb);
>> +                     lock_kernel();
>
> Shouldnt this be a conditional-unlock, so that if the remount moves
> away from under the BKL we dont break in this place?
[...]

Please excuse me I'm only a stupid howler monkey. :-)

Patch with conditional-unlock/lock follow in a second.

Thank you!

Ciao,
Alessio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/