linux-kernel - [PATCH] FRV: utrace: Miscellaneous fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090427232833.491.25088.stgit@warthog.procyon.org.uk>
Date:	Tue, 28 Apr 2009 00:28:33 +0100
From:	David Howells <dhowells@...hat.com>
To:	torvalds@...l.org, akpm@...ux-foundation.org
Cc:	dhowells@...hat.com, hch@....de, roland@...hat.com,
	linux-kernel@...r.kernel.org
Subject: [PATCH] FRV: utrace: Miscellaneous fixes

Fixes for the FRV utrace/tracehook code:

 (1) Macro task_pt_regs()'s argument should be bracketed when used.

 (2) The dest data pointer for user_regset_copyin() should point to the place
     at which the data at position start_pos begins.

Signed-off-by: David Howells <dhowells@...hat.com>
---

 arch/frv/include/asm/ptrace.h |    2 +-
 arch/frv/kernel/ptrace.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/arch/frv/include/asm/ptrace.h b/arch/frv/include/asm/ptrace.h
index 5f8b5e4..a54b535 100644
--- a/arch/frv/include/asm/ptrace.h
+++ b/arch/frv/include/asm/ptrace.h
@@ -81,7 +81,7 @@ extern unsigned long user_stack(const struct pt_regs *);
 extern void show_regs(struct pt_regs *);
 #define profile_pc(regs) ((regs)->pc)
 
-#define task_pt_regs(task) (task->thread.frame0)
+#define task_pt_regs(task) ((task)->thread.frame0)
 
 #define arch_has_single_step()	(1)
 extern void user_enable_single_step(struct task_struct *);
diff --git a/arch/frv/kernel/ptrace.c b/arch/frv/kernel/ptrace.c
index e847945..60eeed3 100644
--- a/arch/frv/kernel/ptrace.c
+++ b/arch/frv/kernel/ptrace.c
@@ -92,7 +92,7 @@ static int genregs_set(struct task_struct *target,
 
 	/* set the general regs */
 	ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
-				 iregs, offs_gr1, sizeof(*iregs));
+				 &iregs->gr[1], offs_gr1, sizeof(*iregs));
 	if (ret < 0)
 		return ret;
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/