[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200904280232.56329.david-b@pacbell.net>
Date: Tue, 28 Apr 2009 02:32:56 -0700
From: David Brownell <david-b@...bell.net>
To: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc: Paul Walmsley <paul@...an.com>, linux-omap@...r.kernel.org,
lrg@...mlogic.co.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator core: fix double-free in regulator_register() error path
On Tuesday 28 April 2009, Mark Brown wrote:
> > For the record, that "incomplete constraints" message is bogus.
> > On that board, VAUX3 has a complete set of constraints: it may
> > only emit 2.8V.
>
> It's not VAUX3 that it's saying has incomplete constraints, it's the
> board as a whole - if the constraints for the board were fully specified
No; driver support != constraint. Only one of the
issues is packaged as a "constraint".
> (and the core had been told about it) then it would power off VAUX3 at
> that point.
>
> > Mark and/or Liam ... you might want to fix that diagnostic, to
> > avoid leading more developers astray!
>
> Probably shove a "board has" in there or something I guess.
How about: "VAUX3 board support is incomplete".
That's accurate.
A comment there might suggest constraints and
driver support as two common issues ... I'd not
be surprised to see a few more idioms pop up.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists