linux-kernel - Re: [PATCH 8/9] x86/irq: make MSI irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090428101448.GA28495@elte.hu>
Date:	Tue, 28 Apr 2009 12:14:48 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 8/9] x86/irq: make MSI irq_desc numa aware -v3

* Yinghai Lu <yinghai@...nel.org> wrote:

> +#ifdef CONFIG_NUMA_IRQ_DESC
> +		/* different node ?*/
> +		if (desc_new->node != node)
> +			desc = move_irq_desc(desc, node);
> +#endif

this should have been CONFIG_NUMA_MIGRATE_IRQ_DESC. But even with 
that fixed, CONFIG_NUMA_MIGRATE_IRQ_DESC is _removed_ in the #2 
patch in your series and never reintroduced!

I've fixed these two bugs in the series and i'm thinking about 
applying them, but this really makes me think how much testing 
you've put into this code.

You really should check that the feature actually does what you 
think, that it can be enabled and you should also check the 
before/after layout of irq descriptors on a NUMA box.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/