linux-kernel - Re: [PATCH -v2] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49F6DB71.10709@linux.intel.com>
Date:	Tue, 28 Apr 2009 12:33:21 +0200
From:	Andi Kleen <ak@...ux.intel.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Huang Ying <ying.huang@...el.com>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v2] x86: MCE: Re-implement MCE log ring buffer as per-CPU
 ring buffer

> We're talking about Machine Check Exceptions here, right? 

No, this is actually more about machine check events (CMCI or poll), not int #18.

> Is there a
> valid scenario where you care about performance? 

Yes corrected errors. They just get reported while the system
keep running.

In practice they can happen in bursts for a relatively short time.
Another case was dumb QA setups where people using high frequency
injection of corrected errors (that was one case the old code didn't handle
too well). Yes I would agree with you that long term high frequency is
not an interesting case still.

However there's another reason why this patchkit is very useful. The old
code didn't scale to a large number of CPUs, that is why the per CPU
buffers are needed.

> Also, it sounds like something that might fit the ftrace ringbuffer
> thingy.

We went over this before. Please read this relevant threads.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/