linux-kernel - Re: [PATCH 03/14] mn10300: Use macros for .bss.page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31713.1240922736@redhat.com>
Date:	Tue, 28 Apr 2009 13:45:36 +0100
From:	David Howells <dhowells@...hat.com>
To:	Tim Abbott <tabbott@....EDU>
Cc:	dhowells@...hat.com, Sam Ravnborg <sam@...nborg.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Anders Kaseorg <andersk@....EDU>,
	Waseem Daher <wdaher@....EDU>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Jeff Arnold <jbarnold@....EDU>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 03/14] mn10300: Use macros for .bss.page_aligned section.

Tim Abbott <tabbott@....EDU> wrote:

> No, it is.  The macro is new in PATCH 1/14 of this series.

Aha!  Okay, I've applied that patch too, and now I see:

  LD      .tmp_vmlinux1
/opt/nickc/H-i686-pc-linux-gnulibc2.3/bin/am33_2.0-linux-gnu-ld:arch/mn10300/kernel/vmlinux.lds:237: syntax error

Where the error occurs on line 237, which is:

	  __bss_start = .; /* BSS */
	  .bss : {
	 . = ALIGN(+(1 << 12)) *(.bss.page_aligned)
	 *(.bss)
 ==>	  }
	  . = ALIGN(4);
	  __bss_stop = .;

in the expanded linker script.

The problem is that your patch #1 is wrong.  You need to apply:

---
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index a76275f..c9b16a6 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -118,11 +118,11 @@
 	TRACE_SYSCALLS()
 
 #define PAGE_ALIGNED_DATA						\
-	. = ALIGN(PAGE_SIZE)						\
+	. = ALIGN(PAGE_SIZE);						\
 	*(.data.page_aligned)
 
 #define PAGE_ALIGNED_BSS						\
-	. = ALIGN(PAGE_SIZE)						\
+	. = ALIGN(PAGE_SIZE);						\
 	*(.bss.page_aligned)
 
 #define RO_DATA(align)							\
---

to it.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/