linux-kernel - Re: mmotm 2009-04-24-18-14 uploaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20954.1240934481@turing-police.cc.vt.edu>
Date:	Tue, 28 Apr 2009 12:01:21 -0400
From:	Valdis.Kletnieks@...edu
To:	Nick Piggin <npiggin@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org
Subject: Re: mmotm 2009-04-24-18-14 uploaded - NVidia indigestion

On Tue, 28 Apr 2009 08:15:57 +0200, Nick Piggin said:

Here's the code (pretty much *all* the code):

> #include <linux/version.h>
> #include <linux/utsname.h>
> int main() {
> 	if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)) {
> 		return 0;
> 	} else {
> 		return 1;
> 	}
> }

> Hmm, yes if you build without -O, then it appears like the compiler
> trips over this. I wouldn't be unhappy with just removing the BUILD_BUG_ON,
> but shouldn't the module be using -O[s2]?

It's a little autoconfig chunk from vendor code that determines if we're
building on a sane/recent kernel.  Not the sort of thing you'd expect to
need to invoke the frikking optimizer for program *correctness* :)



Content of type "application/pgp-signature" skipped